Improve localhost SSL integration docs [ci skip] #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think having these notes documented will be helpful, for sure, but I did notice a few opportunities to make the docs a bit more concise and clear. Generally, I think more concise docs are more readable and, therefore, more accessible.
That's just my opinion though! Feel free to disregard any of these suggested changes, if they don't seem right. 👍 😄
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
|
Very good suggestions @jacobherrington, I applied all of them. Thanks! |
[ci skip]
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Close puma#2706 [ci skip] Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since localhost v1.1.9 (socketry/localhost@a4fe7db) just
require "localhost"works: #2610 (comment)Close #2706
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.