Add new test framework files, test for PR #2675 #2694
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some of the test files for a new test framework that (hopefully) will make it easier to write simpler tests. Also, more complete and reliable tests, more data to see the affects of PR's, etc.
The also adds a test for PR #2675,
TestPOpenSSL#test_persistent_close
. The test sends twenty requests to a Puma server, after each request, it pauses 1.5 seconds, with configpersistent_timeout
set to 1 second.Request time results for master, using Ubuntu 20.04 & Ruby head:
Request time results for PR #2675, using Ubuntu 20.04 & Ruby head:
This shows the benefit of the fixes in PR #2675. Also, there is a new file in the docs folder (test_puma_intro.md), which is the start of a description of the framework, along with comments in the files. Going forward, I may make changes, add benchmark files (some soon), and start to convert the current tests to the new framework. Work in my fork shows they can be much more consistent...
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.