Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test framework files, test for PR #2675 #2694

Closed
wants to merge 2 commits into from

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Sep 8, 2021

Description

This PR includes some of the test files for a new test framework that (hopefully) will make it easier to write simpler tests. Also, more complete and reliable tests, more data to see the affects of PR's, etc.

The also adds a test for PR #2675, TestPOpenSSL#test_persistent_close. The test sends twenty requests to a Puma server, after each request, it pauses 1.5 seconds, with config persistent_timeout set to 1 second.

Request time results for master, using Ubuntu 20.04 & Ruby head:

  20 successful requests (10 loops of 2 clients * 1 request per client)
          10%    20%    40%    50%    60%    80%    90%    95%    97%    99%   100% 
    mS      0      0      0    130    330   5740   9540  13020  13020  13020  13520

Request time results for PR #2675, using Ubuntu 20.04 & Ruby head:

  20 successful requests (10 loops of 2 clients * 1 request per client)
          10%    20%    40%    50%    60%    80%    90%    95%    97%    99%   100% 
    mS  2.927  3.049  3.252  3.288  3.320  3.390  3.838  4.876  4.876  4.876  5.707

This shows the benefit of the fixes in PR #2675. Also, there is a new file in the docs folder (test_puma_intro.md), which is the start of a description of the framework, along with comments in the files. Going forward, I may make changes, add benchmark files (some soon), and start to convert the current tests to the new framework. Work in my fork shows they can be much more consistent...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Sep 8, 2021

Rebased with PR #2675, all the tests that failed originally should now pass, excepting intermittent failures...

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Jan 1, 2022

Will post updated PR soon. I.Hope

@MSP-Greg MSP-Greg closed this Jan 1, 2022
@MSP-Greg MSP-Greg deleted the pr-2675-test-mstr branch September 25, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant