Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threadpool deadlock fix to history for 5.4.0 [ci skip] #2671

Merged

Conversation

cjlarose
Copy link
Member

Description

I'm pretty sure History.md is mostly automatically generated and then manually cleaned up, but I think #2656 probably should've made the cut.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec nateberkopec merged commit 9e2f5d1 into puma:master Jul 30, 2021
@MSP-Greg
Copy link
Member

JFYI, the automated 'history/changelog' code only adds PR's that have a label of one of the following. The mapping is in the same json file that contains the GitHub token, so it is repo specific, and can be changed.

bug
feature
perf
refactor

These are used to group them in the log. I thought that the code lists current PR's that are not labeled, I'll double check...

@MSP-Greg
Copy link
Member

I'm fixing the code. Current code only lists PR's as 'bad' if there are no labels. The PR this adds (#2656) has a 'waiting for review' label, which is often removed immediately before the PR is merged.

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants