Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for the PROXY protocol (v1 only) #2654

Merged
merged 4 commits into from Sep 7, 2021
Merged

add support for the PROXY protocol (v1 only) #2654

merged 4 commits into from Sep 7, 2021

Commits on Jun 30, 2021

  1. add support for the PROXY protocol (v1 only)

    @Roguelazer
    Roguelazer committed Jun 30, 2021
    Copy the full SHA
    b2416e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. slightly simplify test

    @Roguelazer
    Roguelazer committed Jul 1, 2021
    Copy the full SHA
    a413d71 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. address review feedback

    @Roguelazer
    Roguelazer committed Jul 2, 2021
    Copy the full SHA
    b844d2c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. move PROXY protocol parsing into its own method; avoid issue with sho… 

    …rt reads

The HTTP parser requires that the buffer be non-empty when it's invoked,
but if the entire buffer was the PROXY protocol, we may sometimes invoke
it with an empty buffer. This causes the following error:

  Puma::HttpParserError: Requested start is after data buffer end.

The fix? Any time we consume the entire buffer for the PROXY protocol,
simply return `false` to indicate that we require more data.
    @Roguelazer
    Roguelazer committed Jul 7, 2021
    Copy the full SHA
    dc93fa7 View commit details
    Browse the repository at this point in the history