Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for low_latency option and fix parsing issue #2631

Merged
merged 3 commits into from May 20, 2021
Merged

Update docs for low_latency option and fix parsing issue #2631

merged 3 commits into from May 20, 2021

Commits on May 18, 2021

  1. Treat low_latency=false as false instead of true 

    Previously the binder.parse code was just checking that the low_latency
key existed, but the docs (and other options) support passing options in
the format `option=false`. This commit now treats `low_latency=false` as
false, while still treating `low_latency` with no `=` as true
    @seangoedecke
    seangoedecke committed May 18, 2021
    Copy the full SHA
    3339999 View commit details
    Browse the repository at this point in the history

  2. Update docs to reflect code behaviour

    @seangoedecke
    seangoedecke committed May 18, 2021
    Copy the full SHA
    ffacfdb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Skip getsockopt tests in JRuby 

    JRuby (at least this version) doesn't support basic Socket constants or
methods

Ref: jruby/jruby#3438
    @seangoedecke
    seangoedecke committed May 19, 2021
    Copy the full SHA
    331cc76 View commit details
    Browse the repository at this point in the history