Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning when running one-worker cluster #2565

Merged
merged 4 commits into from Mar 9, 2021
Merged

Print warning when running one-worker cluster #2565

merged 4 commits into from Mar 9, 2021

Commits on Mar 7, 2021

  1. Print warning when running one-worker cluster

    Running Puma in cluster-mode is likely a misconfiguration in most
    scenarios.
    
    Cluster mode has some overhead of running an addtional 'control' process
    in order to manage the cluster. If only running a single worker it is
    likely not worth paying that overhead vs running in single mode with
    additional threads instead.
    
    There are some scenarios where running cluster mode with a single worker
    may still be warranted and valid under certain deployment scenarios, see
    the linked issue for details.
    
    From experience at work, we were able to migrate our Rails applications
    from single worker cluster to single-mode and saw a reduction of RAM
    usage of around ~15%.
    
    Closes #2534
    CGA1123 committed Mar 7, 2021
    Copy the full SHA
    39e840e View commit details
    Browse the repository at this point in the history
  2. Remove link to issue

    CGA1123 committed Mar 7, 2021
    Copy the full SHA
    d41f392 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    3e5954a View commit details
    Browse the repository at this point in the history
  4. Test single_worker_warning

    CGA1123 committed Mar 7, 2021
    Copy the full SHA
    b52d994 View commit details
    Browse the repository at this point in the history