New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor response writes, test refactors, fix UNPACK_TCP_STATE_FROM_TCP_INFO location #2554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-Greg
force-pushed
the
refacto-02-14
branch
from
February 15, 2021 20:32
8ce1571
to
03c3e3e
Compare
MSP-Greg
changed the title
Refactor some code used for generating responses, test refactors [changelog skip]
Refactor some code used for generating responses, test refactors
Feb 15, 2021
MSP-Greg
force-pushed
the
refacto-02-14
branch
from
February 15, 2021 20:49
03c3e3e
to
dad016b
Compare
Also added a fix for check_changelog.yml, missing a paren... REMOVED: see b0bd212 |
Oops, my bad (26776c8), however, I think you could add that paren directly to master :) |
MSP-Greg
force-pushed
the
refacto-02-14
branch
from
February 15, 2021 23:29
dad016b
to
62e1c1e
Compare
MSP-Greg
changed the title
Refactor some code used for generating responses, test refactors
Refactor response writes, test refactors, fix UNPACK_TCP_STATE_FROM_TCP_INFO location
Mar 7, 2021
8 tasks
Rebased |
7 tasks
Closing in favor of #2595. I will extract test updates and maybe a few lib updates (3.3, 3.4, ??) from this into another pr... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
request.rb
1.1. Refactor
handle_request
1.2. Refactor and simplify
fast_write
for fewer string assignmentsminissl.rb
2.1. Refactor and simplify
write
for fewer string assignmentsserver.rb
3.1 Move
UNPACK_TCP_STATE_FROM_TCP_INFO
to correct location3.2. Add
PURGE_INTERRUPT_QUEUE
constant3.3. Refactor
cork_socket
,uncork_socket
, &closed_socket?
to work with ssl sockets3.4. Return from above before entering begin block
3.5 Anchor Ruby 'root' constants, e.g.
Socket
andTCPSocket
test_puma_server.rb
4.1 Add multi-byte characters to
test_very_large_return
4.2 Cleanup
@server.stop
code, misctest_puma_server_ssl.rb
5.1. Add multi-byte characters to
test_very_large_return
5.2. Rename a few variables, quotes, misc
NOTES:
Code refactors done while working on updated test framework.
CI using updated tests - MRI, non-MRI. At the bottom of the test step log, see 'Debugging Info`, and click open to see various integration test info.
Closes #2556
Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.