Log the configuration if an env variable is provided #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karloscodes
force-pushed
the
2414-print-config
branch
2 times, most recently
from
5b0e2f7
to
da8eeae
Compare
karloscodes
force-pushed
the
2414-print-config
branch
2 times, most recently
from
3e16989
to
6cfd722
Compare
nateberkopec
requested changes
Oct 30, 2020
nateberkopec
added
waiting-for-changes
karloscodes
force-pushed
the
2414-print-config
branch
6 times, most recently
from
a358bd2
to
91a3e83
Compare
|
Feedback addressed :) I'd appreciate some help with the naming, especially with /cc @nateberkopec and @MSP-Greg |
karloscodes
force-pushed
the
2414-print-config
branch
from
91a3e83
to
bb774d5
Compare
|
I'll leave it to @nateberkopec, but we might consider whether to add PUMA to the ENV name, it can help with 'what does this affect?' questions... |
nateberkopec
requested changes
Nov 1, 2020
karloscodes
force-pushed
the
2414-print-config
branch
from
bb774d5
to
76f58e7
Compare
|
Feedback addressed |
nateberkopec
added
waiting-for-review
|
Brilliant, great feature. |
|
Thanks you so much @nateberkopec and @MSP-Greg for the support 😄 |
This was referenced Mar 8, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for printing the puma config if an env variable is provided as agreed in #2414
I'm aware am missing several things including the tests but I just want early feedback if possible, this is my first contribution to the project :)
Closes #2414
Here is an example of the output:
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.