Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fork_worker does not work with preload_app! [changelog skip] #2468

Merged
merged 1 commit into from
Oct 29, 2020
Merged

fork_worker does not work with preload_app! [changelog skip] #2468

merged 1 commit into from
Oct 29, 2020

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Oct 28, 2020 •
edited

See the discussion in #2467

Related to #2466
Close #2467

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg dentarg mentioned this pull request Oct 28, 2020
Closed
@nateberkopec nateberkopec merged commit f0dffd4 into puma:master Oct 29, 2020
@dentarg dentarg deleted the improve-docs branch November 7, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fork_worker and refork, is it working? yes (with "preload_app!"? no)
2 participants
@dentarg @nateberkopec