Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test to help prevent JSON loading regressions [changelog skip] #2436

Merged

Conversation

cjlarose
Copy link
Member

@cjlarose cjlarose commented Oct 20, 2020

Description

This change adds an integration test for the changes in #2269, in order to prevent regressions similar to #1801.

It's important that in a puma cluster, that the master process doesn't require the json gem, because doing to makes it not possible for users to upgrade or downgrade their application using a phased restart if they change the version of the json gem they're using.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@cjlarose cjlarose changed the title Add integration test help prevent JSON loading regressions [changelog skip] Add integration test to help prevent JSON loading regressions [changelog skip] Oct 20, 2020
@cjlarose cjlarose force-pushed the add-json-gem-defined-integration-test branch from b77a05f to c0009f5 Compare October 20, 2020 18:55
@nateberkopec nateberkopec merged commit 3f0913a into puma:master Oct 20, 2020
@nateberkopec
Copy link
Member

Great thinking! Glad we added this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants