Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test adding connection to Reactor after shutdown [changelog skip] #2418

Merged
merged 3 commits into from Oct 8, 2020
Merged

Test adding connection to Reactor after shutdown [changelog skip] #2418

merged 3 commits into from Oct 8, 2020

Commits on Oct 7, 2020

  1. Test adding connection to Reactor after shutdown 

    Modifies `TestPumaServer#shutdown_requests` to pause `Reactor#add` until after
shutdown begins, to ensure requests are handled correctly for this edge case.
Adds unit-test coverage for the fix introduced in puma#2377 and updated in puma#2279.
    @wjordan
    wjordan committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    147175e View commit details
    Browse the repository at this point in the history

  2. Fix Queue#close implementation for Ruby 2.2 

    Allow `ClosedQueueError` to be raised when `Queue#<<` is called.
    @wjordan
    wjordan committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    0f4e51f View commit details
    Browse the repository at this point in the history

  3. Pass @block directly instead of @block.method(:call)

    @wjordan
    wjordan committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    e5d04eb View commit details
    Browse the repository at this point in the history