Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server - Consolidate option handling, small refactors, doc changes #2389

Merged
merged 2 commits into from Sep 29, 2020

Conversation

MSP-Greg
Copy link
Member

Description

Taken from PR #2373, added attr_writer's to maintain API, marked items as deprecated in v6.0.0.

PR #2373 included tests fixes. Those fixes will be anther PR, this shows that no API changes have been made that break CI here. I also double checked...

Small timing adjustment for a test that intermittently failed locally.

For one example similar to most of the fixes, see #2373 (comment)

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants