Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified as per tooling suggestions [changelog skip] #2379

Closed
wants to merge 1 commit into from

Conversation

ignacionr
Copy link

Description

This is helping resolve https://github.com/puma/puma/runs/1053004549 that prevent CI from deploying #2314 esp. Rubocop's complaint.

As per the checklist below, this should include a tag to skip CI, but can't do since fixing CI is what it does :)

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

I don't really want to merge into 4.3.5, it's a dead branch because that release is already out. Is this problem fixed on master/4.3.6?

@ignacionr
Copy link
Author

I understand. The company I am working for, is now open to updating their version to 4.3.6, which seems to compile without warnings (warnings were the issue with the recent update of Xcode on the Mac).

Thanks for considering it though.

@ignacionr
Copy link
Author

Cancelled request.

@ignacionr ignacionr closed this Sep 24, 2020
@nateberkopec
Copy link
Member

Cheers. You made me realize we should be doing 4-3-stable, rails-style branching anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants