Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog skip] Move integration logging test to main test suite #2347

Merged
merged 2 commits into from
Sep 5, 2020
Merged

[changelog skip] Move integration logging test to main test suite #2347

merged 2 commits into from
Sep 5, 2020

Conversation

sudheer-meka
Copy link

@sudheer-meka sudheer-meka commented Aug 28, 2020 •
edited

This PR moves the 3rd and the last of the 3 integration tests mentioned in #2172 that live in the test/shell directory into the main test suite.

Closes 2172

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@sudheer-meka sudheer-meka mentioned this pull request Aug 28, 2020
Closed
@nateberkopec nateberkopec added maintenance waiting-for-review Waiting on review from anyone labels Sep 5, 2020
@nateberkopec nateberkopec merged commit a6f14e1 into puma:master Sep 5, 2020
@nateberkopec
Copy link
Member

Awesome! So excited to finally be rid of that.

@sudheer-meka
Copy link
Author

@nateberkopec thanks for merging, please do let me know if there is any other issues which I can fix.

@sudheer-meka sudheer-meka deleted the move-integration-tests-to-regular-suite branch September 22, 2020 11:28
@wjordan wjordan mentioned this pull request Sep 23, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance waiting-for-review Waiting on review from anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fold the old integration tests into the new test suite.
3 participants
@sudheer-meka @nateberkopec @sumeka