Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive prune_bundler #2323

Merged
merged 2 commits into from Sep 3, 2020

Conversation

AlexWayfer
Copy link
Contributor

Description

Resolve #2319

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

Ah nice, I think this explains the problems I've had with these tests locally.

@nateberkopec nateberkopec added the waiting-for-review Waiting on review from anyone label Jul 31, 2020
@nateberkopec
Copy link
Member

Fixes the issue for me locally! 🥇

@nateberkopec nateberkopec merged commit a2302d6 into puma:master Sep 3, 2020
@AlexWayfer AlexWayfer deleted the fix_recursive_bundler_pruining branch April 15, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug important! waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic restarts with prune_bundler and Bundler.setup (require) and workers > 1
2 participants