Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MiniSSL for users without OpenSSL available #2303

Closed
wants to merge 2 commits into from
Closed

Improve MiniSSL for users without OpenSSL available #2303

wants to merge 2 commits into from

Commits on Jul 3, 2020

  1. Check if OPENSSL_VERSION is defined in MiniSSL 

    For people who did not install from OpenSSL extension,

Here https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L12 is false, and they hit SSLError https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L555-L562

Check if the OPENSSL_VERSION is defined to fix this.

Co-Authored-By: Matthew Draper <matthew@trebex.net>
Co-Authored-By: Samuel Cochran <sj26@sj26.com>
    @JuanitoFatas @matthewd @sj26
    3 people committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    5ed1f5b View commit details
    Browse the repository at this point in the history

  2. Add a changelog for detecting OpenSSL in MiniSSL

    @JuanitoFatas
    JuanitoFatas committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    a97585c View commit details
    Browse the repository at this point in the history