Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Log binding on http:// for TCP bindings to make it clickable #2300

Merged
merged 4 commits into from Jul 6, 2020

Conversation

alexeevit
Copy link
Contributor

@alexeevit alexeevit commented Jun 29, 2020

Description

It's duplicate of #2167 synced with the master branch.

Closes #2166

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@alexeevit alexeevit changed the title Log binding on http:// for TCP bindings to make it clickable WIP Log binding on http:// for TCP bindings to make it clickable Jun 29, 2020
@alexeevit
Copy link
Contributor Author

Hm, I'm not sure I can fix these issues with truffleruby.
@nateberkopec do we need it?

@nateberkopec nateberkopec merged commit e2b4193 into puma:master Jul 6, 2020
@alexeevit alexeevit deleted the feature/change-log-tcp-to-http branch July 12, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log binding on http:// for TCP bindings to make it clickable
3 participants