Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI using the default version of Bundler [changelog skip] #2292

Merged
merged 2 commits into from Jun 7, 2020

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Jun 6, 2020

Description

Run CI using the default version of Bundler

  • Which is Bundler on Ruby 2.2 and Bundler 2 on Ruby 2.3+.

This used to fail on TruffleRuby (fixed in oracle/truffleruby#1984) and on Ruby 2.3 (due to ruby/setup-ruby#51, now fixed).

Do not set the --path for bundle install

cc @MSP-Greg, I'm not sure why the --path was set but it doesn't seem needed.

* Which is Bundler on Ruby 2.2 and Bundler 2 on Ruby 2.3+.
* This is buggy with Ruby 2.3 + Bundler 2.1.4,
  see ruby/setup-ruby#51
@nateberkopec
Copy link
Member

@MSP-Greg all you on this one

@nateberkopec nateberkopec added the waiting-for-review Waiting on review from anyone label Jun 7, 2020
@MSP-Greg
Copy link
Member

MSP-Greg commented Jun 7, 2020

@nateberkopec

Thanks.

@eregon and I spent some of today working on changes to the actions used here and elsewhere, and both of us ran Puma CI in our forks to test them.

There may be some changes tomorrow. I'm tired of thinking about Actions workflows right now...

@dentarg
Copy link
Member

dentarg commented Jun 7, 2020

Re: --path, it was added in #2126, not sure in reaction to what.

In the past, the old build system, Travis, used --path: #1893 (comment)

@eregon
Copy link
Contributor Author

eregon commented Jun 7, 2020

Right, --path is often used for caching.
Bundler caching is coming in ruby/setup-ruby#56 and setting an explicit value conflicts with that (i.e., does not use the cache), so let's remove it.

@MSP-Greg
Copy link
Member

MSP-Greg commented Jun 7, 2020

I think --path is being discouraged in favor of bundle config, so probably best to remove. Caching can be done in another PR.

LGTM

@MSP-Greg MSP-Greg merged commit f049c5d into puma:master Jun 7, 2020
@eregon eregon deleted the bundler2 branch June 7, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants