Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parse error to output a single line log [changelog skip] #2261

Merged
merged 1 commit into from May 15, 2020

Conversation

lucaspiller
Copy link
Contributor

@lucaspiller lucaspiller commented May 14, 2020

Description

This changes the error when an HTTP parse error is encountered so it outputs a single line to the error log. Our logging system (Loggly) expects a single line per error, and it doesn't support filtering the second line (---) as it contains special characters. As discussed in #986 we experience these errors often on AWS, so is causing a lot of noise for us.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

Yeah, that extra line is a little wacky. This will probably get fixed anyway by #2250, but I'll merge this until then.

@nateberkopec nateberkopec merged commit 5a8cbe3 into puma:master May 15, 2020
@lucaspiller lucaspiller deleted the http-parse-error-log branch June 1, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants