Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert api change from #2086 introduce Puma.stats_hash api #2253

Merged
merged 2 commits into from May 11, 2020
Merged

Revert api change from #2086 introduce Puma.stats_hash api #2253

merged 2 commits into from May 11, 2020

Commits on May 8, 2020

  1. Rubocop

    @schneems
    schneems committed May 8, 2020
    Copy the full SHA
    b39268b View commit details
    Browse the repository at this point in the history

  2. Revert api change from #2086 introduce Puma.stats_hash api 

    The change in #2086 is not backwards compatible with existing gems that parse the output of Puma.stats such as barnes.

Releasing a version of puma with this change would break anyone using the Barnes app and only in production. I'm proposing to keep the existing interface and instead add a new API. This buys us all the features of #2086 without causing any production facing downtime by customers due to API incompatibilities.

Unfortunately it requires that we serialize and the de-serialize the values. One prior benefit of returning json in a string was that it allowed an end user to de-serialize using a faster json algorithm such as `oj` via the "multi json" gem. But the performance penalty will be better than a stability break.
    @schneems
    schneems committed May 8, 2020
    Copy the full SHA
    0cbace3 View commit details
    Browse the repository at this point in the history