Prefer rackup file specified by CLI #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2020 22:31
test/test_integration_single.rb
Outdated
| @@ -43,6 +43,19 @@ def test_term_suppress | |||
| assert_equal 0, status | |||
| end | |||
|
|
|||
| def test_prefer_rackup_file_specified_by_cli | |||
| skip_unless_signal_exist? :TERM | |||
| skip_on :jruby | |||
test/test_integration_single.rb
Outdated
| _, status = stop_server | ||
|
|
||
| assert_match("Hello World", reply) | ||
| assert_equal 15, status |
There was a problem hiding this comment.
This assertion isn't necessary I think, we only need the correct reply.
|
Thank you so much! Can you confirm this new test fails on master? |
nateberkopec
added
bug
waiting-for-changes
|
All changes requested were made.
Yes, I confirm. |
Co-Authored-By: Cristian Rivera <cristian_rivera@me.com>
|
Is it possible to backport this to 4.3? We are experiencing this issue with puma 4.3 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to always give preference for the rackup file specified by the CLI. I also took opportunity and added some tests.
This Closes #2225 .
Your checklist for this pull request
[changelog skip]the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.