Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Connection: closed when running without request queueing #2216

Merged
merged 6 commits into from Apr 6, 2020
Merged

Set Connection: closed when running without request queueing #2216

merged 6 commits into from Apr 6, 2020

Commits on Apr 2, 2020

  1. Fix test requires

    praboud-stripe committed Apr 2, 2020
    Copy the full SHA
    b4c38ba View commit details
    Browse the repository at this point in the history
  2. Refactor how the HTTP connection header is set

    This helps make it clearer how this branching works, and explicitly
    documents that this is a difference in which default HTTP 1.0 vs 1.1
    assume.
    praboud-stripe committed Apr 2, 2020
    Copy the full SHA
    345e127 View commit details
    Browse the repository at this point in the history
  3. Fix Connection header when not using queue_requests

    When running with queue_requests=false, make the Connection header
    reflect that the server will close the connection after the request is
    completed.
    
    (This is required by
    https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html, specifically:
    "HTTP/1.1 applications that do not support persistent connections MUST
    include the "close" connection option in every message.")
    
    This could previously cause clients which looked at this header to
    attempt to reuse connections which the server had closed.
    praboud-stripe committed Apr 2, 2020
    Copy the full SHA
    6346bfe View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. History

    praboud-stripe committed Apr 3, 2020
    Copy the full SHA
    8901a77 View commit details
    Browse the repository at this point in the history
  2. Re-roll CI builds

    praboud-stripe committed Apr 3, 2020
    Copy the full SHA
    5d18d1c View commit details
    Browse the repository at this point in the history
  3. Rebuild again

    praboud-stripe committed Apr 3, 2020
    Copy the full SHA
    dd9825b View commit details
    Browse the repository at this point in the history