Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on TruffleRuby, all tests pass now #2198

Merged
merged 15 commits into from Mar 24, 2020

Commits on Mar 22, 2020

  1. Support skip_on :truffleruby

    eregon committed Mar 22, 2020
    Copy the full SHA
    e804787 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8b060d9 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f7f1f0c View commit details
    Browse the repository at this point in the history
  4. Improve NO_FORK_MSG

    eregon committed Mar 22, 2020
    Copy the full SHA
    4069ec8 View commit details
    Browse the repository at this point in the history
  5. Keep the Tempfile instances alive in test_redirect_io.rb

    * Otherwise they could GC in the middle of the test, and the files could
      then be deleted.
    eregon committed Mar 22, 2020
    Copy the full SHA
    2c8a1e4 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    5166a47 View commit details
    Browse the repository at this point in the history
  7. Read directly from the socket in #read_and_drop

    * There is no point to decode the bytes since we are closing the socket
      in Puma::MiniSSL::Socket#close.
    * Also, calling #engine_read_all might cause further SSL errors, which
      could hide the first SSL error. This notably happens in
      TestPumaServerSSLClient#test_verify_fail_if_no_client_cert
      if the server is faster than the client. The error in that case is
      "System error: Success - 0 (Puma::MiniSSL::SSLError)" which is not
      actually an error, but there is also nothing to read further from SSL.
    eregon committed Mar 22, 2020
    Copy the full SHA
    e461d1e View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Copy the full SHA
    e9ce579 View commit details
    Browse the repository at this point in the history
  2. Use a timeout of 120 for all non-MRI implementations

    * 60 doesn't seem enough in CI for TestThreadPool#test_trim on TruffleRuby.
    eregon committed Mar 24, 2020
    Copy the full SHA
    4ed3e53 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e3706b5 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    63d3fc2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    2285288 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    d7c5cc2 View commit details
    Browse the repository at this point in the history
  7. Add ChangeLog entry

    eregon committed Mar 24, 2020
    Copy the full SHA
    ae98fa9 View commit details
    Browse the repository at this point in the history
  8. No need to run RuboCop on non-MRI implementations

    * This should speed up CI a bit for those jobs.
    eregon committed Mar 24, 2020
    Copy the full SHA
    646d73a View commit details
    Browse the repository at this point in the history