Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two Ruby 2.2 issues, add to Actions & remove from Travis [changelog skip] #2146

Merged
merged 2 commits into from Mar 4, 2020

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Mar 4, 2020

Description

Note that Ruby 2.2 needs a RubyGems update to pass.

Closes #2145

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Mar 4, 2020

  1. It's time to skip OpenSSL 1.0.1 CI. Travis Ruby 2.2 uses OpenSSL 1.0.1f, dated 6 Jan 2014. Just no...

  2. The PR added to two <io>.closed? checks, I didn't do so conditionally based on the Ruby version. Ok, or change?

@nateberkopec
Copy link
Member

Those are fine. A conditional would be overkill here IMO.

@nateberkopec nateberkopec merged commit 9b5137a into puma:master Mar 4, 2020
@MSP-Greg MSP-Greg deleted the ruby-2-2 branch March 4, 2020 17:39
@MSP-Greg
Copy link
Member Author

MSP-Greg commented Mar 4, 2020

@nateberkopec

I saw the failure on the commit of this, and in my fork ran CI with the seed value (--seed 21956).

Not pretty. Every single Ubuntu & macOS job failed. I assume it's an unstable test(s) with UNIXSocket or fork (maybe a Signal also), because all the Windows jobs passed.

CI is at:
https://github.com/MSP-Greg/puma/actions/runs/49629001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 2.2 build failing
2 participants