New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RAILS_MIN_THREADS, RAILS_MAX_THREADS, set default worker, preload… #2143
Changes from 16 commits
b606a33
d37ba21
70e2ae9
0593668
2ba0d6e
5a95dae
ebc1422
d8b72e8
e1a1750
d24455c
b257dfe
b2dad7b
e552e6c
3645f75
6200e52
c12340b
338099f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,7 +109,7 @@ def in_background(&blk) | |
end | ||
|
||
def workers_supported? | ||
return false if Puma.jruby? || Puma.windows? | ||
return false if Puma.jruby? || Puma.windows? || Puma.truffle? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we check ::Process.respond_to?(:fork) as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in my nitpick commit. Thanks for the work on this PR! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sweet! |
||
true | ||
end | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method feels like it should be in the lib/puma/detect.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nateberkopec