Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescue IO::WaitReadable instead of EAGAIN for blocking read #2121

Merged
merged 2 commits into from Feb 21, 2020
Merged

Rescue IO::WaitReadable instead of EAGAIN for blocking read #2121

merged 2 commits into from Feb 21, 2020

Commits on Feb 20, 2020

  1. Add test for waiting with an open client connection

    @wjordan
    wjordan committed Feb 20, 2020
    Copy the full SHA
    37ac08e View commit details
    Browse the repository at this point in the history

  2. Rescue IO::WaitReadable instead of EAGAIN for blocking read 

    On Windows, `read_nonblock` raises `Errno::EWOULDBLOCK` if a blocking read would occur, which is a different value from `Errno::EAGAIN`. Both of these errors are extended by `IO::WaitReadable` which is Ruby's recommended exception class for retrying `read_nonblock`.
    @wjordan
    wjordan committed Feb 20, 2020
    Copy the full SHA
    3304499 View commit details
    Browse the repository at this point in the history