Run test_http_rejection without code updates [changelog skip] #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It passed on 2.2 on Travis. |
Sorry, wasn't clear. It should pass on any Ruby build using OpenSSL 1.0.2, and Ruby 2.2 uses 1.0.2. It will not pass on any build using 1.1.1, which is the first OpenSSL version with TLSv1.3. EDIT: a simpler way to say this is that the added test will pass with TLSv1.2 and lower. The problem is only caused by servers that accept the connection with TLSv1.3 and then wait for the SSL connection to be established... |
|
I'm ok to close this, I thought showing that the test failed on current master was worth having record of... |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only the test component of PR #2116
It should fail on any CI jobs using OpenSSL 1.1.1, which is Ruby 2.4 and later on all platforms, with one exception of Ruby 2.4 on Windows.
Sorry, meant to make this a draft. It should not be merged.