Add processed requests counter to workers #2061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes are pretty basic for now. What do you think ? Should we count hijacked connections ? What about TCP connections (lopez mode) ? I see this feature as a HTTP requests counter so the code looks good as it is but there is probably some edge case that I forgot 😄 |
|
LGTM. I'm not really worried about hijacked or TCP requests for a first iteration. We can leave that for the future. |
nateberkopec
requested changes
Oct 31, 2019
nateberkopec
requested changes
Oct 31, 2019
|
Indeed, I've just tested the feature locally, I will add a spec.
…On Thu, Oct 31, 2019, 5:36 PM Nate Berkopec ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I just realized - one thing we don't have here is a test that the counter
actually increments! We should have tests for both single and cluster mode.
Probably in the integration test files (test_integration_*.rb) would make
sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2061?email_source=notifications&email_token=ABG633KYHDOI3QLRD4OS3VTQRMCPNA5CNFSM4JGP3WCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJ5IYSY#pullrequestreview-310021195>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG633KF5QLWHJEMK4Z5RULQRMCPNANCNFSM4JGP3WCA>
.
On Thu, Oct 31, 2019, 5:36 PM Nate Berkopec ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I just realized - one thing we don't have here is a test that the counter
actually increments! We should have tests for both single and cluster mode.
Probably in the integration test files (test_integration_*.rb) would make
sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2061?email_source=notifications&email_token=ABG633KYHDOI3QLRD4OS3VTQRMCPNA5CNFSM4JGP3WCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJ5IYSY#pullrequestreview-310021195>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG633KF5QLWHJEMK4Z5RULQRMCPNANCNFSM4JGP3WCA>
.
|
|
Those tests are failing on Windows. I think we should probably use something other than curl. |
nateberkopec
requested changes
Nov 27, 2019
|
#2106 got there first. Thanks for starting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR implementing feature #2057
Your checklist for this pull request
[changelog skip]to all commit messages.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.