Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL support for the control app #2046

Merged
merged 2 commits into from Oct 21, 2019
Merged

Add SSL support for the control app #2046

merged 2 commits into from Oct 21, 2019

Commits on Oct 20, 2019

  1. Extract class for building SSL context 

    This commit extracts the `MiniSSL::Context` creation into its own
`MiniSSL::ContextBuilder` class along the same lines as in [puma#1989].

This will allow us to reuse this code for adding SSL support to the
control app (issue [puma#2015]). Since we will need the `MiniSSL` require
and check in both places, I moved that into the `ContextBuilder` class
as well.

[puma#1989]: puma#1989
[puma#2015]: puma#2015
    @composerinteralia
    composerinteralia committed Oct 20, 2019
    Copy the full SHA
    f8938f4 View commit details
    Browse the repository at this point in the history

  2. Add SSL support for the control app 

    This starts to address [puma#2015]. I think we will need to add SSL support
to the control cli as well.

[puma#2015]: puma#2015
    @composerinteralia
    composerinteralia committed Oct 20, 2019
    Copy the full SHA
    fe06bac View commit details
    Browse the repository at this point in the history