Fix peeraddr raises Errno::EINVAL inside reactor

[hahmed]

Hey @nateberkopec

I had a look into the issue #1564 and could not easily mock the object that returns the peeraddr as its inside the reactor class.

Possible reasons why this error could occur? https://github.com/ruby/ruby/blob/ddf5020e4fcae5ed28a064af10124a032590452f/ext/socket/socket.c#L366

• Errno::EINVAL - the address length used for the sockaddr is not a valid
• Errno::EINVAL - the +socket+ is already bound to an address, and the
• protocol does not support binding to the new sockaddr or the socket has been shut down.
• Errno::EINVAL - the address length is not a valid length for the address family

My idea was to create a test that has an expired SSL, that means we hit this part of the code

puma/lib/puma/reactor.rb

Line 234 in 1817773

rescue MiniSSL::SSLError => e

then have the peeraddr throw from a mocked object, but could not seem to do that.

Any idea on how I can do this, or is there another way I can go about writing a test for this?

[nateberkopec]

Yikes. I got about neck-deep into this one before I realized we would need a ground-up redesign of Reactor and Client to really stub this correctly, or give up and use any-instance mocks.

Merging without a test, under great pain.

[nateberkopec]

Closed w 70e381d

Thanks for your 👀 @hahmed, this one turned out to be a lot more complicated to test than almost anything we've looked at yet...

[hahmed]

Thanks, yeah I tried everything to find a way to test this, at least I learned a lot about how the reactor works 😂