Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binder fixes for 4.2.1 #2006

Merged
merged 3 commits into from Oct 1, 2019
Merged

Binder fixes for 4.2.1 #2006

merged 3 commits into from Oct 1, 2019

Commits on Oct 1, 2019

  1. Adds failing test for #1986. We now have failing tests for both that … 

    …issue and #1994
    @nateberkopec
    nateberkopec committed Oct 1, 2019
    Copy the full SHA
    69412b1 View commit details
    Browse the repository at this point in the history

  2. Fix #1986. Fix #1994

    @nateberkopec
    nateberkopec committed Oct 1, 2019
    Copy the full SHA
    ca9e244 View commit details
    Browse the repository at this point in the history

  3. Fixup and reorder test a bit 

    Original test was using localhost + port 0 for ssl, two things which
will not be corretly supported in 4.2.1. Instead, test for 127.0.0.1 and
a real port with SSL, which we do support correctly today.

Also re-use test method for the ssl test.
    @nateberkopec
    nateberkopec committed Oct 1, 2019
    Copy the full SHA
    b85c6c1 View commit details
    Browse the repository at this point in the history