Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_integration files per PR #1956 #1965

Merged
merged 6 commits into from Sep 19, 2019
Merged

Update test_integration files per PR #1956 #1965

merged 6 commits into from Sep 19, 2019

Commits on Sep 19, 2019

  1. Update test_integration files per PR puma#1956 

    test_integration_cluster.rb

Request handling during server TERM - two tests

`#test_term_closes_listeners_tcp`
`#test_term_closes_listeners_unix`

using `#term_closes_listeners`

Send requests 10 per second.  Send 10, then :TERM server, then send another 30.
No more than 10 should throw Errno::ECONNRESET.

Request handling during phased restart - two tests

`#test_usr1_all_respond_tcp`
`#test_usr1_all_respond_unix`

using `#usr1_all_respond`

Send requests 1 per second.  Send 1, then :USR1 server, then send another 24.
All should be responded to, and at least three workers should be used

Stuck worker tests - two tests

`#test_stuck_external_term_spawn`
Tests whether externally TERM'd 'stuck' workers are proper re-spawned.

`#test_stuck_phased_restart`
Tests whether 'stuck' workers are properly shutdown during phased-restart.

helper files/methods changes

1. helper file changes to allow binding to TCP or UNIX, see kwarg unix:
2. Skip on Windows for signal TERM
    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    445cf50 View commit details
    Browse the repository at this point in the history

  2. Misc updates, debug output, cleanup

    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    fa0f801 View commit details
    Browse the repository at this point in the history

  3. Add comments

    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    d9aa2aa View commit details
    Browse the repository at this point in the history

  4. fix test_int_signal_with_background_thread_in_jruby per review

    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    5f8157c View commit details
    Browse the repository at this point in the history

  5. TestIntegrationCluster#term_closes_listeners - add interleaved assert

    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    e261fef View commit details
    Browse the repository at this point in the history

  6. cluster.rb - remove duplicate Worker#term? method

    @MSP-Greg
    MSP-Greg committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    ef49bbd View commit details
    Browse the repository at this point in the history