[PR 1952] 1st verification - updated tests & GitHub Actions #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. test_integration.rb - Rewrite so all tests create a server via IO.popen. 2. Update some tests for parallelize_me! 3. Add config/worker_shutdown_timeout_2.rb, rackup/sleep_pid.ru
This reverts commit 4256bc0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1952, I stated that an updated set of tests I was using showed false positives in the test that checked correct operation/timing for re-spawning of externally
TERM'd signals.This PR has five commits:
Lib changes
GitHub Actions
Test changes
Reverting first commit
Reverting the macOS update to Ruby 2.4.7, which is causing current Travis to fail.
Hence, this PR shows that the current master fails with the updated tests.