cluster.rb - remove worker #dead?, #dead!, @dead

[MSP-Greg]

While working on PR #1908, I added a Worker method #term? to indicate whether Worker#term had been called. Also, previous code that rejected workers from the @workers array where dead? was true was removed.

At the time, I wondered what dead's purpose was. It was also bothersome that workers contain threads, and alive? is a thread method, and most would consider dead to be the inverse. Also, it's confusing, especially since code and comments in thread_pool.rb refer to dead_workers...

Upon reviewing the code, I cannot see anywhere where the state of Worker#dead? or @dead is used. It is set here on line 510:

puma/lib/puma/cluster.rb

Lines 503 to 512 in 9fb1228

	if w = @workers.find { |x| x.pid == pid }
	case req
	when "b"
	w.boot!
	log "- Worker #{w.index} (pid: #{pid}) booted, phase: #{w.phase}"
	force_check = true
	when "t"
	w.dead!
	force_check = true
	when "p"

This PR changes line 510 to 'w.term' and removes the two 'dead' methods. If this seems improper, the PR could be changed to call #term in Cluster#check_workers for any dead workers...

EDIT: This may also help intermittent test_integration.rb failures in macOS builds on Travis, which I've seen in my fork, as I can't test cluster locally..

[nateberkopec]

This may also help intermittent test_integration.rb failures in macOS builds on Travis, which I've seen in my fork, as I can't test cluster locally..

welp, guess that didn't work

I've notice the 2.4 one fails more often than the 2.5 one

[nateberkopec]

Great catch, agreed that this is dead code.

[nateberkopec]

Looks like it was added here 3fdf0c9 and the delete_if? dead has been removed at some point in the intervening years.