test_integration.erb - fix intermittent test #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes test_sigterm_closes_listeners_on_forked_servers When the test was added in PR puma#1802, it used the rackup/1second.ru file, which provided a fixed one second delay. PR puma#1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls. The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
nateberkopec
pushed a commit
that referenced
this pull request
Sep 5, 2019
Fixes test_sigterm_closes_listeners_on_forked_servers When the test was added in PR #1802, it used the rackup/1second.ru file, which provided a fixed one second delay. PR #1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls. The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test_sigterm_closes_listeners_on_forked_servers
When the test was added in PR #1802, it used the rackup/1second.ru file, which provided a fixed one second delay.
PR #1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls.
The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
The 2nd connect call loaded the next_replies array, which was the array that was failing in it's assert.
PR #1903 was my PR, so apologies for the mistake.