New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve BUNDLE_GEMFILE and add a test for it #1893
Merged
Merged
Commits on Aug 8, 2019
-
Preserve BUNDLE_GEMFILE and add a test for it
Starting your server with BUNDLE_GEMFILE=Gemfile.rails6 would delete this environment variable on app restart when using `--prune-bundler`, when all you really want is to restore the variable to what it was before Bundler was activated. I mimicked the existing code that preserves GEM_HOME. Co-authored-by: James Miller <bensie@gmail.com>
-
Go back to using Bundler.with_original_env
Test that the environment is not lost when doing a restart by using the PATH env var as a canary. While we actually care about the BUNDLER_GEMFILE env var, that one is harder to set up in testing since it requires a full copy of Puma's Gemfile. This change also has the benefit of not only protecting the BUNDLE_GEMFILE var, but also the other variables that Bundler knows about.
-
-
Commits on Aug 19, 2019
Commits on Feb 12, 2020
-
-
Preserve BUNDLE_GEMFILE and other Bundler env vars
Starting your server with BUNDLE_GEMFILE=Gemfile.rails6 would delete this environment variable on app restart when using --prune-bundler, when all you really want is to restore the variable to what it was before Bundler was activated. Writing a test for this proved to be difficult because the bug only seems to manifest itself when running the server under the following conditions: - Using `bundle exec` to run the puma command - Using a non-zero number of workers, e.g. `-w 2` - Setting `BUNDLE_GEMFILE` to something other than "Gemfile"
-
-
Commits on Feb 13, 2020
-
On my machine, the USR2 signal was being sent to Bash, but not to to puma itself. I don't understand why this only affected Ruby 2.2 though!
-
-
This test was failing on Travis when run in parallel with other tests in the TestIntegrationCluster test. Removing the line "parallelize_me!" from the top of the file worked, but I chose to move the test into its own file to keep the existing tests running in parallel.
-
-
-
-
-
-
-
-
-
-
-
-
Bundler wins. Just set BUNDLE_GEMFILE manually
...and go back to using Bundler.with_clean_env.
-
-
Commits on Feb 14, 2020
Commits on Feb 18, 2020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.