Swallow connection errors when sending early hints #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the future proof version of that GitHub link. |
I've been thinking on how Puma should behave when the early hints can't be sent because the connection has been lost. I first thought that it should behave the same way it does when the connection is lost before main response is sent, I've seen that it swallows those errors (https://git.io/fjVtg) so perhaps we should do the same here. There's one consideration though. Because the early hints are sent at the very beginning of the app execution, we may want to abort this request altogether and save resources by throwing an exception and causing Rails to interrupt execution. Finally I decided to overlook that case just because I believe it's least surprising from the Rack app point of view. Also I haven't seen any other example of the web server interrupting the apps execution due to an error on the lower layer. Fixes puma#1640.
|
I've updated both the Github message & the commit message with your link. Thank you! |
|
Works for me. I think you could write a test that just has fast_write blow up/raise. |
|
Test added and I think this is ready to merge 🚢 |
nateberkopec
removed
the
waiting-for-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking on how Puma should behave when the early hints
can't be sent because the connection has been lost.
I first thought that it should behave the same way it does when the
connection is lost before main response is sent, I've seen that it
swallows those errors (https://git.io/fjVtg) so perhaps we should do
the same here.
There's one consideration though. Because the early hints are sent at
the very beginning of the app execution, we may want to abort this
request altogether and save resources by throwing an exception and
causing Rails to interrupt execution.
Finally I decided to overlook that case just because I believe it's
least surprising from the Rack app point of view. Also
I haven't seen any other example of the web server interrupting
the apps execution due to an error on the lower layer.
Fixes #1640.