Friendlier dev setup #1580
Merged
Friendlier dev setup #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure looks unrelated, culprit could be #1487. |
deivid-rodriguez
force-pushed
the
dev_friendly_setup
branch
from
248f4e0
to
8c18027
Compare
deivid-rodriguez
force-pushed
the
dev_friendly_setup
branch
from
8c18027
to
4379ebc
Compare
|
I rebased this PR since master is now green. |
deivid-rodriguez
force-pushed
the
dev_friendly_setup
branch
from
4379ebc
to
1c57c56
Compare
deivid-rodriguez
force-pushed
the
dev_friendly_setup
branch
from
1c57c56
to
bb98151
Compare
|
Rebased again now that master is green again. |
Don't force everyone running puma's tests to uninstall every gem matching /puma/ from their system. Whatever problem this was fixing, it seems like the wrong solution for it... :/
deivid-rodriguez
force-pushed
the
dev_friendly_setup
branch
from
bb98151
to
13b0657
Compare
|
New year, new rebase! 😝 |
|
In particular, I was asked not only to remove all versions of puma from my system, but also |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was really surprised that puma would ask me to remove every single gem matching /puma/ from my system, just to be able to run puma's tests.... Whatever problem this was fixing, it feels like the wrong solution for it... I mean, this is what
bundleris for, right?