allow app to also handle sighup and call super

[grosser]

our app wants to reopen rails logs on sighup
to do that it needs to trap sighup too
but calling pumas trap after does not work since it crashes the server if redirect_io was not used

with this change there is 1 less trap used and our app can only call pumas trap if it was set

see zendesk/samson#2637

/cc @ragurney @jonmoter

[nateberkopec]

Doesn't this change mean SIGHUP will no longer call stop?

[grosser]

it will kill the process (default behavior of SIGHUP) ... not sure if that's bad ... would certainly stop the server :D

ruby -e sleep
kill -HUP 39052
Hangup: 1

[nateberkopec]

@grosser What I meant was you eliminated this branch of code, and I don't understand why.

[grosser]

I was basically thinking "if you send SIGHUP to a server that does not have any reload mechanic then wtf are you doing" ... but maybe it's valid usecase :(

[nateberkopec]

I think it was important to #1377?

[grosser]

that PR is about SIGINT not SIGHUP stop for SIGHUP was added in eb6468d to fix #911 which is about SIGTERM ... idk kinda confusing :D

…

On Tue, Mar 27, 2018 at 4:28 PM, Nate Berkopec ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/puma/launcher.rb <#1527 (comment)>: > @runner.redirect_io - else I think it was important to #1377 <#1377> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1527 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ5uFTg2cTdnNaQRUs3g9VwRbnUfFks5tissMgaJpZM4SjsLw> .

[nateberkopec]

SIGWHYDONTWECALLTHEWHOLETHINGOFF

[grosser]

#911 has reproduction steps, so if they still work then it's ok ?
it's not really an urgent/important change, just 1-more-weirdness in the codebase 🤷‍♂️

[evanphx]

I'm going to reject this PR because it changes the meaning of SIGHUP for existing users.