Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minissl read_nonblock fix #1444

Closed
wants to merge 1 commit into from
Closed

minissl read_nonblock fix #1444

wants to merge 1 commit into from

Conversation

MSP-Greg
Copy link
Member

Travis is having intermittent errors across various releases. This seems to fix issue. Just went thru a bit of nonblock code variations in ruby core.

Please review, as I haven't really been outside of this code/file...

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Oct 20, 2017 •
edited

@nateberkopec

I hate it when this happens.

Travis:
My fork build passed. Travis here did two builds, first #2534 passed, second #2535 failed.

Appveyor:
My fork passed, Appveyor here (just one build) failed only on trunk, with a 'Could not build wrapper using Ragel' error on line 114 of the log. I haven't seen that in previous tests. I can add a ragel package to Appveyor, but it's not normally installed. Odd that the error just appeared.

EDIT: ragel can be added two ways. If it's required to install/compile the packaged gem, it should be added to the metadata in the gemspec. If it's only required here for CI, then it should be added in the appveyor.yml file.

olleolleolle
olleolleolle reviewed Oct 31, 2017
View reviewed changes
lib/puma/minissl.rb
end
end
end while true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason not to use loop do ... end for this loop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It'd introduce a block, making data block-local.)

@MSP-Greg MSP-Greg mentioned this pull request Nov 19, 2017
Closed
@MSP-Greg
Copy link
Member Author

See #1464 and 7165775

@MSP-Greg MSP-Greg closed this Nov 20, 2017
@MSP-Greg MSP-Greg deleted the minissl_nonblock branch November 20, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MSP-Greg @olleolleolle @nateberkopec