Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1344 (bundle exec startup without RUBYOPT present) #1348

Closed
wants to merge 2 commits into from

Conversation

bughit
Copy link

@bughit bughit commented Jun 27, 2017

No description provided.

@stereobooster
Copy link
Contributor

stereobooster commented Jul 1, 2017

Related #1344

UPD Need to do better investigation before merging this

@bughit
Copy link
Author

bughit commented Jul 6, 2017

@stereobooster
the investigation is here: #1344 (comment)

@bughit
Copy link
Author

bughit commented Jul 24, 2017

@stereobooster @nateberkopec

My investigation (#1344 (comment)) showed that in a bundle exec puma invocation if puma resolves to a ruby script rather than say a bash rbenv shim, then this puma ruby script will be loaded in process and Bundler::ORIGINAL_ENV["RUBYOPT"] will not be set. In fact nothing set by the following will be in ORIGINAL_ENV

def set_bundle_environment
      set_bundle_variables
      set_path
      set_rubyopt
      set_rubylib
end

Is that not sufficient to proceed with the fix? Or are there other expectations/assumptions for what's in ORIGINAL_ENV than need to be dealt with?

@nateberkopec
Copy link
Member

Closing in favor of #1385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants