Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1265: Load environment-specific config file #1269

Closed
wants to merge 1 commit into from

Conversation

ma11hew28
Copy link

@ma11hew28 ma11hew28 commented Apr 10, 2017

@options[:environment] is a lambda literal.

@options[:environment].call returns the environment string, eg, "development".

@nateberkopec
Copy link
Member

👍 Needs a test though.

@nateberkopec nateberkopec added bug waiting-for-changes Waiting on changes from the requestor labels May 1, 2017
@nateberkopec
Copy link
Member

Ping, happy to merge with a test 👍

@ma11hew28
Copy link
Author

I'm sorry. I don't know how to write a test for this, but when I tried it out, it worked for me.

@allaire
Copy link
Contributor

allaire commented May 7, 2017

Experiencing this issue as well

@allaire
Copy link
Contributor

allaire commented May 26, 2017

I don't understand, going back to puma 3.6.0 fix the environment config not loading bug, but it seems that this version is also using a proc for @options[:environment], which got me thinking it might be something else?

I think #1284 is similar

In my case, on 3.6.0, having exec bundle exec puma -p 5010 in my upstart scripts works and correctly load the right environment file (defined by RACK_ENV).

@nateberkopec
Copy link
Member

I think #1340 is a more complete solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug waiting-for-changes Waiting on changes from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants