Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative schemes in Binder #3302

Open
benburkert opened this issue Dec 29, 2023 · 0 comments · May be fixed by #3348
Open

Allow alternative schemes in Binder #3302

benburkert opened this issue Dec 29, 2023 · 0 comments · May be fixed by #3348

Comments

@benburkert
Copy link
Contributor

Is your feature request related to a problem? Please describe.

To get this acme plugin working, I had to monkey-patch Puma::Binder#parse calls to add a hook system, so that a custom scheme (e.g. bind "acme://0.0.0.0:44333") would work with (hot-)reloading.

Describe the solution you'd like

A way of registering a new scheme with a callback so that the parse method could be extended to work with this plugin, without resorting to money-patches.

Describe alternatives you've considered

None that work well with the reloading & socket inheritance functionality.

Additional context

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants