Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] turbo-rails is now passing #3076

Merged
merged 1 commit into from Feb 10, 2023
Merged

Conversation

MSP-Greg
Copy link
Member

Description

Turbo-Rails had an async issue that caused intermittent failures in CI. That has been fixed, so the workflow can have the 'continue-on-error'/'allow-failure' code removed.

Turbo-Rails uses 'full hijacking' to create a websocket connection.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit fcf5f84 into puma:master Feb 10, 2023
@MSP-Greg MSP-Greg deleted the 00-turbo-rails-fix branch May 11, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant