Remove daemonization #2170
Merged
Remove daemonization #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
force-pushed
the
remove-daemon
branch
from
bd54342
to
1c9e863
Compare
nateberkopec
force-pushed
the
remove-daemon
branch
from
1c9e863
to
306fb3c
Compare
nateberkopec
force-pushed
the
remove-daemon
branch
from
306fb3c
to
fca64ed
Compare
|
Please take a look - this functionality has been extracted into puma-daemon ruby gem. I would love some additional testing if you'd like to use daemonization with 5+ Puma |
pixeltrix
added a commit
to ScottishParliament/e-petitions
that referenced
this pull request
Jan 28, 2021
The daemonization code was removed in puma/puma#2170 which is the right thing to do but we'll need to switch to a systemd script so lock to a previous version while we get that sorted.
@kigster Thank you for this! We are using it to help upgrade to Puma 5 without having to refactor some smoketesting scripts we have. |
|
Glad it's working out for you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1983