Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puma does not restart after update from 4.0.0 to 5.0.2 #310

Closed
incubus opened this issue Dec 18, 2020 · 1 comment
Closed

Puma does not restart after update from 4.0.0 to 5.0.2 #310

incubus opened this issue Dec 18, 2020 · 1 comment

Comments

@incubus
Copy link

incubus commented Dec 18, 2020

Hi!

We are using monit and puma 4.3.7. Here is the output from capistrano logs:

capistrano-puma 5.0.2:

01:51 puma:monit:monitor
      01 sudo /usr/bin/monit monitor puma_test_staging
    ✔ 01 test@host.com 0.718s
01:53 deploy:cleanup
      Keeping 5 of 6 deployed releases on host.com
      01 rm -rf /home/test/test/releases/20201216151012
    ✔ 01 test@host.com 1.088s
01:56 deploy:log_revision
      01 echo "Branch master (at e00b333e4b35ab517ef2d24f440026c0e4b9f661) deployed as release 20201218040023 by incubus" >> /hom…
    ✔ 01 test@host.com 0.694s

Capistrano does not start puma:restart task.

capistrano-puma 4.0.0:

01:40 puma:monit:monitor
      01 sudo /usr/bin/monit monitor puma_test_staging
    ✔ 01 test@host.com 0.653s
01:42 deploy:cleanup
      Keeping 5 of 6 deployed releases on host.com
      01 rm -rf /home/test/test/releases/20201216151730
    ✔ 01 test@host.com 0.884s
01:45 deploy:log_revision
      01 echo "Branch master (at e00b333e4b35ab517ef2d24f440026c0e4b9f661) deployed as release 20201218041750 by incubus" >> /hom…
    ✔ 01 test@host.com 0.624s
01:48 puma:restart
      01 $HOME/.rbenv/bin/rbenv exec bundle exec pumactl -S /home/test/test/shared/tmp/pids/puma.state -F /home/test/test/sha…
      01 Command restart sent success
    ✔ 01 test@host.com 1.316s

Did I miss something? Thanks!

@crackofdusk
Copy link

I ran into this problem as well. The tasks were moved from Capistrano::Puma to Capistrano::Puma::Daemon

From the readme:

install_plugin Capistrano::Puma::Daemon

Note that this is incompatible with Puma 5+ as daemonization support was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants