tests - clean up - three commits #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failed on Xcode11 Ruby 2.4.6. Most of the intermittent failures seem to involve this particular job. Anyone know what the standard Ruby version is with newer macOS versions? Maybe we should change it to 2.6.3? |
MSP-Greg
force-pushed
the
test-helpers-app
branch
from
d022ba4
to
e3fe79a
Compare
clean up, mutex removes port issues with parallel testing
MSP-Greg
changed the title
|
All three Travis builds passed. There was a single ruby 2.3.3p222 (32 bit) job that failed on AppVeyor, which is an old version of 2.3 (most recent is 2.3.8). I have seen the method fail before. Human readable error text: |
|
|
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Aug 23, 2019
Fixes test_sigterm_closes_listeners_on_forked_servers When the test was added in PR puma#1802, it used the rackup/1second.ru file, which provided a fixed one second delay. PR puma#1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls. The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
nateberkopec
pushed a commit
that referenced
this pull request
Aug 23, 2019
Fixes test_sigterm_closes_listeners_on_forked_servers When the test was added in PR #1802, it used the rackup/1second.ru file, which provided a fixed one second delay. PR #1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls. The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
nateberkopec
pushed a commit
that referenced
this pull request
Sep 5, 2019
* tests - cleanup rackup folder, add sleep.ru, add helpers/app.rb * tests - change nextport to UniquePort.call, remove nextport, mutex clean up, mutex removes port issues with parallel testing * test_integration.rb - make UNIXSocket file names unique
nateberkopec
pushed a commit
that referenced
this pull request
Sep 5, 2019
Fixes test_sigterm_closes_listeners_on_forked_servers When the test was added in PR #1802, it used the rackup/1second.ru file, which provided a fixed one second delay. PR #1903 removed the 1second.ru file and added a sleep.ru file, which allowed variable timing. But, the 'sleep1' path was added to only one of the test's two connect calls. The test has passed most of the time, but intermittently fails. This adds the 1 second delay to the 2nd connect call, which should make it stable.
nateberkopec
pushed a commit
that referenced
this pull request
Sep 9, 2019
* tests - cleanup rackup folder, add sleep.ru, add helpers/app.rb * tests - change nextport to UniquePort.call, remove nextport, mutex clean up, mutex removes port issues with parallel testing * test_integration.rb - make UNIXSocket file names unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 'tests - cleanup rackup folder, add sleep.ru, add helpers/app.rb' - Cleans up rackup folder, adds sleep.ru, which allows setting request 'sleep' time via the URI. Add companion 'app' in
TestApps::SLEEP. See Issue testing - rackup folder - sleep #1902.Commit 'tests - change nextport to UniquePort.call, remove nextport, mutex' - helper.rb currently has two methods to select an unused port. Removed the
nextportmethod, and added a mutex toUniquePort.callfor parallel testing.Commit 'test_integration.rb - make UNIXSocket file names unique` - for parallel testing