Freeze all the strings!

[schneems]

Reduces runtime allocation by freezing string literals by default.

We could also remove a ton of manual .freeze calls, however the ruby supported version is 2.2 and the magic comment only targets 2.3+.

[MSP-Greg]

I tested the patch for this in my fork, Appveyor & Travis passed, but Travis failed on both Ruby trunk jobs, although probably not due to this PR.

[nijikon]

@schneems Support for ruby 2.2 ended on March 31, 2018. I think that we should utilize new features of the language, people who use 2.2 could still use puma but to a particular version which I think it's fine.

[tmikoss]

After deploying version 3.12.1 in production, I'm getting regular "can't modify frozen strings" errors when trying to establish actioncable websocket connections, pointing at https://github.com/faye/websocket-driver-ruby/blob/0.7.0/lib/websocket/driver/draft76.rb#L11, without any application code in the backtrace.

Could it be linked to this? Running on ruby 2.5.3 / rails 5.2.2.1. Would a complete backtrace help?

[schneems]

Can you give a small example app that reproduces the problem and open an issue? https://www.codetriage.com/example_app

On Thu, Apr 4, 2019 at 9:07 AM Toms Mikoss ***@***.***> wrote: After deploying version 3.12.1 in production, I'm getting regular "can't modify frozen strings" errors when trying to establish actioncable websocket connections, pointing at https://github.com/faye/websocket-driver-ruby/blob/0.7.0/lib/websocket/driver/draft76.rb#L11, without any application code in the backtrace. Could it be linked to this? Running on ruby 2.5.3 / rails 5.2.2.1. Would a complete backtrace help? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1649 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADpYNKBFNSJmDjB7JkQ3hbb4wiqYNoQks5vdgc1gaJpZM4WsTHe> .

-- Richard Schneeman https://www.schneems.com