Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use # frozen_string_literal: true #1587

Closed
jjb opened this issue May 25, 2018 · 2 comments
Closed

use # frozen_string_literal: true #1587

jjb opened this issue May 25, 2018 · 2 comments

Comments

@jjb
Copy link
Contributor

jjb commented May 25, 2018

Has the project considered adding # frozen_string_literal: true to all source files? AFAIK this has possibly significant benefits with no drawbacks.

@schneems
Copy link
Contributor

If you can send a PR that passes the test I see no reason not to use it.

AFAIK this has possibly significant benefits with no drawbacks.

I've done memory benchmarking with derailed benchmarks and never found a hotspot inside of puma. That being said, every little bit helps as long as it doesn't cause significant pain or errors, i'm for it 👍.

@jjb
Copy link
Contributor Author

jjb commented Oct 24, 2018

done in #1649 🎉

@jjb jjb closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants