Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require ruby 2.2+ in gemspec #1506

Merged
merged 3 commits into from May 9, 2018
Merged

require ruby 2.2+ in gemspec #1506

merged 3 commits into from May 9, 2018

Conversation

dekellum
Copy link
Contributor

@dekellum dekellum commented Jan 19, 2018 •
edited

As of 0ed4ba8, we are no longer running CI for ruby < 2.2. Per #1440, puma hasn't actually been compatible with ruby 1.9 since puma 3.8.0.

github: fixes #1440

@dekellum
require ruby 2.2+ in gemspec
aa66d1d 
As of 0ed4ba8, we are no longer running CI for ruby < 2.2. Per puma#1440,
puma hasn't actually been compatible with ruby 1.9 since puma 3.8.0.

github: fixes puma#1440
@dekellum
Don't run ruby 2.1 in appveyor either
260630e
@dekellum
Remove obsolete 2.1-Gemfile
826daf1
olleolleolle
olleolleolle approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clarifies and simplifies. I'm for this change!

@olleolleolle olleolleolle mentioned this pull request Feb 6, 2018
Closed
deivid-rodriguez
deivid-rodriguez approved these changes Apr 22, 2018
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good move. Puma doesn't work on older versions, and that seems intentional, so it should not be installable at all.

@nateberkopec nateberkopec merged commit 825bf85 into puma:master May 9, 2018
@benoittgt benoittgt mentioned this pull request Jul 15, 2018
Closed
@bdewater bdewater mentioned this pull request Jan 19, 2019
Merged
jage referenced this pull request in twingly/twingly-url Feb 5, 2019
@jage
Update Changelog with unreleased changes
8216124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with Ruby < 2.1 (undefined method `to_h')
4 participants
@dekellum @olleolleolle @deivid-rodriguez @nateberkopec